Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: false postive with binutils-gold #387

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: false postive with binutils-gold #387

merged 1 commit into from
Mar 16, 2024

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Mar 15, 2024 •
edited

What does this PR do?

The binutils-gold package provides a command named ld.gold, not binutils-gold.

@crazywhalecc crazywhalecc added bug Something isn't working kind/framework Issues related to CLI app framework os/linux Things only for Linux OS labels Mar 16, 2024
@crazywhalecc crazywhalecc merged commit 96c3e6b into crazywhalecc:main Mar 16, 2024
21 checks passed
@dunglas dunglas deleted the fix/binutils-gold branch March 16, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywhalecc crazywhalecc crazywhalecc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working kind/framework Issues related to CLI app framework os/linux Things only for Linux OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dunglas @crazywhalecc