Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Mineshafts #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for Mineshafts #38

wants to merge 1 commit into from

Conversation

Paril
Copy link

@Paril Paril commented Jul 3, 2014

Adds support for a Mineshaft layer to the map viewer.

@crbednarz
Copy link
Owner

Has this been tested for accuracy, and do you know what versions of Minecraft it would apply to?

@Paril
Copy link
Author

Paril commented Jul 5, 2014

Only tested on 1.7.10 - accurate on that version. Haven't looked back to see if it fit any other versions. Sorry for it not being more specific. I made this simply because I needed to find a Mineshaft in my world and this was quicker than scouring the world, heh.

@Paril
Copy link
Author

Paril commented Jul 5, 2014

I should mention I do know that this won't work in early 1.7/1.6 versions, as they had a different value in the RNG area (they had 0.1 instead of 0.02 or something like that). At the moment I am 100% sure it works with 1.7.10 but I can't really guarantee any earlier ones (1.7.9 is probably consistent. Basically until the last world gen change I would imagine).

Treer added a commit to Treer/AmidstExporter that referenced this pull request May 6, 2015
crbednarz#38
Will test it later (including against older versions)
@Treer
Copy link
Contributor

Treer commented May 9, 2015

Actually your layer works successfully all the way back to version 1.4.2.

Mineshafts don't appear where predicted in v1.3.2 or earlier, so 1.4.2 is the version where this layer becomes accurate.

@Treer
Copy link
Contributor

Treer commented Jul 22, 2015

c7f971f makes this Mineshaft layer show the extra mineshafts present in versions prior to 1.7.2.

(my testing back to 1.4.2 confirmed all the mineshafts in the layer were present, but because v1.6 has all the 1.7 mineshafts and more, my testing didn't expose the ones that were lacking. This change should fix that aspect)

And 9ebb54d makes this Mineshaft layer compatible with all the versions that predate 1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants