Add unit tests for non-redhat and redhat distributions

pkg/crc/preflight/preflight_darwin_test.go

@@ -0,0 +1,19 @@
+package preflight
+
+import (
+	"testing"
+
+	"github.com/code-ready/crc/pkg/crc/config"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCountConfigurationOptions(t *testing.T) {
+	cfg := config.New(config.NewEmptyInMemoryStorage())
+	RegisterSettings(cfg)
+	assert.Len(t, cfg.AllConfigs(), 20)
+}
+
+func TestCountPreflights(t *testing.T) {
+	assert.Len(t, getPreflightChecks(false), 10)
+	assert.Len(t, getPreflightChecks(true), 16)
+}

pkg/crc/preflight/preflight_linux_test.go

@@ -0,0 +1,27 @@
+package preflight
+
+import (
+	"testing"
+
+	"github.com/code-ready/crc/pkg/crc/config"
+	crcos "github.com/code-ready/crc/pkg/os/linux"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCountConfigurationOptions(t *testing.T) {
+	cfg := config.New(config.NewEmptyInMemoryStorage())
+	RegisterSettings(cfg)
+	options := len(cfg.AllConfigs())
+	assert.True(t, options == 40 || options == 32)
+}
+
+func TestCountPreflights(t *testing.T) {
+	assert.Len(t, getPreflightChecksForDistro(crcos.RHEL, false), 21)
+	assert.Len(t, getPreflightChecksForDistro(crcos.RHEL, true), 21)
+
+	assert.Len(t, getPreflightChecksForDistro("unexpected", false), 21)
+	assert.Len(t, getPreflightChecksForDistro("unexpected", true), 21)
+
+	assert.Len(t, getPreflightChecksForDistro(crcos.Ubuntu, false), 17)
+	assert.Len(t, getPreflightChecksForDistro(crcos.Ubuntu, true), 17)
+}

pkg/crc/preflight/preflight_test.go

@@ -2,37 +2,12 @@ package preflight
 
 import (
 	"errors"
-	"runtime"
 	"testing"
 
 	"github.com/code-ready/crc/pkg/crc/config"
 	"github.com/stretchr/testify/assert"
 )
 
-func TestCountConfigurationOptions(t *testing.T) {
-	cfg := config.New(config.NewEmptyInMemoryStorage())
-	RegisterSettings(cfg)
-	assert.Len(t, cfg.AllConfigs(), map[string]int{
-		"darwin":  20,
-		"linux":   40,
-		"windows": 24,
-	}[runtime.GOOS])
-}
-
-func TestCountPreflights(t *testing.T) {
-	assert.Len(t, getPreflightChecks(false), map[string]int{
-		"darwin":  10,
-		"linux":   21,
-		"windows": 14,
-	}[runtime.GOOS])
-
-	assert.Len(t, getPreflightChecks(true), map[string]int{
-		"darwin":  16,
-		"linux":   21,
-		"windows": 16,
-	}[runtime.GOOS])
-}
-
 func TestCheckPreflight(t *testing.T) {
 	check, calls := sampleCheck(nil, nil)
 	cfg := config.New(config.NewEmptyInMemoryStorage())

pkg/crc/preflight/preflight_windows_test.go

@@ -0,0 +1,19 @@
+package preflight
+
+import (
+	"testing"
+
+	"github.com/code-ready/crc/pkg/crc/config"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCountConfigurationOptions(t *testing.T) {
+	cfg := config.New(config.NewEmptyInMemoryStorage())
+	RegisterSettings(cfg)
+	assert.Len(t, cfg.AllConfigs(), 24)
+}
+
+func TestCountPreflights(t *testing.T) {
+	assert.Len(t, getPreflightChecks(false), 14)
+	assert.Len(t, getPreflightChecks(true), 16)
+}

pkg/os/linux/release_info.go

@@ -45,6 +45,7 @@ const (
 	RHEL   OsType = "rhel"
 	Fedora OsType = "fedora"
 	CentOS OsType = "centos"
+	Ubuntu OsType = "ubuntu"
 )
 
 func stripQuotes(val string) string {