Skip to content

Commit

Permalink
macos: Make launchd processes interactive
Browse files Browse the repository at this point in the history
When (and only when) starting hyperkit from a crc daemon instance
started through launchd, we've seen unexpected kernel panics in the
guest: #2020

If crc daemon is run from a console, this does not happen. If hyperkit
is run directly from a launchd service, even using different (Debian)
kernels, and nothing crc related, the kernel panic is reproducible.
Newer/older hyperkit versions exhibit this behaviour as well.
These panics happen more or less frequently depending on the machine,
for me they were happening 80% of the time.

Starting the crc daemon launchd service as an interactive process avoids
this problem (but don't ask me why exactly :-/ )

This fixes #2020
  • Loading branch information
cfergeau authored and praveenkumar committed Mar 18, 2021
1 parent 98ad4f6 commit 84f47f4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/os/launchd/launchd_darwin.go
Expand Up @@ -36,6 +36,8 @@ const (
<false/>
<key>RunAtLoad</key>
<true/>
<key>ProcessType</key>
<string>Interactive</string>
</dict>
</plist>`
)
Expand Down

0 comments on commit 84f47f4

Please sign in to comment.