Issue #743 make setup steps skippable due to incorrect Administrator …

…role check

This is a workaround for issue #742. The current codebase performs the
wrong check for Administrator; a Domain User with the Administrator
role is wrongly identified as being the local Administrator.

pkg/crc/preflight/preflight_darwin.go

@@ -54,11 +54,11 @@ func StartPreflightChecks(vmDriver string) {
 
 // SetupHost performs the prerequisite checks and setups the host to run the cluster
 func SetupHost(vmDriver string) {
-	preflightCheckAndFix(false,
+	preflightCheckAndFix(config.GetBool(cmdConfig.SkipCheckRootUser.Name),
 		checkIfRunningAsNormalUser,
 		fixRunAsNormalUser,
 		"Checking if running as non-root",
-		false,
+		config.GetBool(cmdConfig.WarnCheckRootUser.Name),
 	)
 	preflightCheckAndFix(false,
 		checkOcBinaryCached,

pkg/crc/preflight/preflight_linux.go

@@ -91,11 +91,11 @@ func StartPreflightChecks(vmDriver string) {
 
 // SetupHost performs the prerequisite checks and setups the host to run the cluster
 func SetupHost(vmDriver string) {
-	preflightCheckAndFix(false,
+	preflightCheckAndFix(config.GetBool(cmdConfig.SkipCheckRootUser.Name),
 		checkIfRunningAsNormalUser,
 		fixRunAsNormalUser,
 		"Checking if running as non-root",
-		false,
+		config.GetBool(cmdConfig.WarnCheckRootUser.Name),
 	)
 	preflightCheckAndFix(false,
 		checkOcBinaryCached,

pkg/crc/preflight/preflight_windows.go

@@ -44,11 +44,11 @@ func StartPreflightChecks(vmDriver string) {
 
 // SetupHost performs the prerequisite checks and setups the host to run the cluster
 func SetupHost(vmDriver string) {
-	preflightCheckAndFix(false,
+	preflightCheckAndFix(config.GetBool(cmdConfig.SkipCheckAdministratorUser.Name),
 		checkIfRunningAsNormalUserInWindows,
 		fixRunAsNormalUserInWindows,
 		"Checking if running as normal user",
-		false,
+		config.GetBool(cmdConfig.WarnCheckAdministratorUser.Name),
 	)
 	preflightCheckAndFix(false,
 		checkOcBinaryCached,