-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong unit while downloading bundle during crc setup
#3627
Labels
Comments
It is not the unit, but the notation that is incorrect, right? This either needs to be |
If this needs to be changed, it needs to be modified in CRC tooling itself This is standard output as per: https://github.com/cheggaaa/pb/ => https://github.com/cheggaaa/pb/blob/224e0746e1e7b9c5309d6e2637264bfeb746d043/v3/speed.go#L74 // ElementSpeed calculates current speed by EWMA
// Optionally can take one or two string arguments.
// First string will be used as value for format speed, default is "%s p/s".
// Second string will be used when speed not available, default is "? p/s"
// In template use as follows: {{speed .}} or {{speed . "%s per second"}} or {{speed . "%s ps" "..."}
var ElementSpeed ElementFunc = func(state *State, args ...string) string {
sp := getSpeedObj(state).value(state)
if sp == 0 {
return argsHelper(args).getNotEmptyOr(1, "? p/s")
}
return fmt.Sprintf(argsHelper(args).getNotEmptyOr(0, "%s p/s"), state.Format(int64(round(sp))))
} |
gbraad
changed the title
Wrong unit while downloading bundle
Wrong unit while downloading bundle during May 4, 2023
crc setup
cfergeau
added a commit
to cfergeau/crc
that referenced
this issue
May 11, 2023
When downloading, the 'per second' suffix is written as 'p/s' which is unexpected. This commit uses a more usual '/s' suffix. This fixes crc-org#3627
anjannath
pushed a commit
that referenced
this issue
May 11, 2023
When downloading, the 'per second' suffix is written as 'p/s' which is unexpected. This commit uses a more usual '/s' suffix. This fixes #3627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While the bundle is downloaded, the unit us MiB p/s. What's the p ? Is this per second ?
The text was updated successfully, but these errors were encountered: