Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crc delete should delete /etc/resolver/testing #487

Closed
AkihiroSuda opened this issue Aug 28, 2019 · 5 comments
Closed

crc delete should delete /etc/resolver/testing #487

AkihiroSuda opened this issue Aug 28, 2019 · 5 comments
Labels
kind/enhancement New feature or request os/linux os/macos priority/minor size/S status/stale Issue went stale; did not receive attention or no reply from the OP

Comments

@AkihiroSuda
Copy link

On macOS, /etc/resolver/testing remains after crc testing. It would be great if crc delete can remove this file as well as the cluster.

@cfergeau
Copy link
Contributor

cfergeau commented Aug 28, 2019

If we remove after crc delete, this means you can't do crc start, you will need to run crc setup again, which will ask for sudo to recreate it, and then you can do crc start. We could make sure /etc/resolver/testing is empty though, similarly to what is requested in issue #296. And an crc unsetup command to undo everything which crc setup did would be useful too.

@gbraad
Copy link
Contributor

gbraad commented Aug 28, 2019

We have a generic cleanup task here: #348 This needs some discussion, as it mostly macOS and Linux now that creates 'unwanted' artifacts when CRC is not used.

However, Docker for Desktop also leaves entries in hosts on Windows... not sure about other platforms. eg.:

# Added by Docker Desktop
10.0.21.112 host.docker.internal
10.0.21.112 gateway.docker.internal
# End of section

@cfergeau
Copy link
Contributor

And another issue related to cleaning up what setup does: #507

@stale
Copy link

stale bot commented Feb 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Feb 11, 2020
@stale stale bot closed this as completed Feb 25, 2020
@gbraad
Copy link
Contributor

gbraad commented Feb 25, 2020

Duplicate of #651

@gbraad gbraad marked this as a duplicate of #651 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request os/linux os/macos priority/minor size/S status/stale Issue went stale; did not receive attention or no reply from the OP
Projects
None yet
Development

No branches or pull requests

3 participants