Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: crc cleanup #507

Closed
opuk opened this issue Aug 29, 2019 · 16 comments
Closed

RFE: crc cleanup #507

opuk opened this issue Aug 29, 2019 · 16 comments
Assignees
Labels
kind/enhancement New feature or request priority/major size/M tags/help wanted Extra attention is needed
Milestone

Comments

@opuk
Copy link
Contributor

opuk commented Aug 29, 2019

It would be nice to have a command like crc cleanup or crc uninstall which cleans up everything that crc setup creates, for example libvirt networks.

@gbraad gbraad added kind/enhancement New feature or request priority/major size/M tags/help wanted Extra attention is needed labels Aug 29, 2019
@gbraad
Copy link
Contributor

gbraad commented Aug 29, 2019

crc cleanup sounds like clearing a/the cache, and crc uninstall sounds like a removal tool. we try to keep our footprint as small as possible (like placing dependencies inside our homedir), but you rae right. We have to look into this and come up with a solution to make this clear or either reduce even more needed setup steps.

@d-laing
Copy link

d-laing commented Aug 29, 2019

+1 to this RFE.

For information, I needed to perform some extra tasks to successfully upgrade to the latest version of Code Ready Containers (crc-linux-1.0.0-beta.3-amd64).

  • Delete the existing .crc directory from my home directory (otherwise, I got an error when running crc start)
  • Delete the existing crc VM from Virtual Machine Manager (perhaps this step would be self-evident for some users)

Many thanks.

@cfergeau
Copy link
Contributor

@laidan6000 crc delete would probably have been enough in your situation. However, this bug is about something different. Schematically, crc delete removes what crc start created, this bug is about removing the changes that crc setup did.

@d-laing
Copy link

d-laing commented Aug 29, 2019

Oh! I didn't think to run crc delete before attempting to setup and start the new version. Thanks for the information!

@gbraad
Copy link
Contributor

gbraad commented Aug 30, 2019 via email

@d-laing
Copy link

d-laing commented Aug 30, 2019

Yes, I had a VM from the alpha release. I got a "missing bundle" error when attempting to start CRC.
Thanks for the assistance.

@cfergeau
Copy link
Contributor

I think this is a duplicate of #348

@praveenkumar
Copy link
Member

@cfergeau #348 is for adding extra net around checking the content we download like oc or machine driver (if the sha doesn't match), this issue more like exposing a clean command for user to unset all the configuration which we did as part of setup command and also remove ~/.crc folder.

@praveenkumar praveenkumar self-assigned this Sep 24, 2019
@cfergeau
Copy link
Contributor

I'm not quite sure what #348 is about to be honest, I'm confused by the wording.

@stale
Copy link

stale bot commented Feb 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Feb 15, 2020
@dlewis7444
Copy link

Bad stalebot! No soup for you!

This Enhancement is really needed. CRC modifies network settings. That's a bad thing for those of us that have heavily modified our network settings.

@stale stale bot removed the status/stale Issue went stale; did not receive attention or no reply from the OP label Feb 17, 2020
@praveenkumar praveenkumar added this to In progress in Sprint 182 Mar 31, 2020
@praveenkumar praveenkumar assigned praveenkumar and unassigned zeenix Mar 31, 2020
@anjannath
Copy link
Member

Fixed via #651 #1153 #1155

@cfergeau
Copy link
Contributor

At this point this is only partially fixed (libvirt group changes on linux for example are not undone).

@planetf1
Copy link

+1 for a full cleanup - I seem to have fallen into a trap with bad network config I am unpicking manually

@anjannath
Copy link
Member

@cfergeau Ahh, right, do you want to keep this issue open, or create a new one, with the remaining things.

@gbraad
Copy link
Contributor

gbraad commented Apr 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request priority/major size/M tags/help wanted Extra attention is needed
Projects
No open projects
Sprint 173
  
To do
Sprint 176
  
In Progress
Sprint 182
  
In progress
Development

No branches or pull requests

10 participants