'crc delete' message could be improved #760
Comments
|
@robin-owen WDYT? To me it sounds more passive when 'was' is used. While correct, it is not a necessary change. |
|
Then maybe, for consistency, I'd suggest also changing the |
|
Is 'running' makes sense as that is a continuous present tense (it is
on-going and still happening). It would not be nice to says "It/The
OpenShift cluster runs".
|
|
@gbraad agreed! Hence the change which @cfergeau suggests makes sense (in an effort to align the messages). And the message about stopping should also be changed since we're at it - I think. The output currently is: The first line suggests that something/someone is stopping the cluster, while the second line suggests that the cluster stopped itself. It'd be better if the second line was |
|
Stopping is not an action that is happening at that moment or will happen.
Is stopping means it will happen now or in the near future. Was stopped is
an unnecessary addition to indicate that the action happened. Please
consult Practical English Grammar or the Oxford Guide to English Grammar By
John Eastwood on this topic.
With a slight nuance, it would be better to say "The cluster has been
deleted" ... or you can avoid the message by just saying; "Operation
successfully finished." and apply that to all actions.
…On Thu, Oct 24, 2019 at 4:02 PM jakub sliacan ***@***.***> wrote:
@gbraad <https://github.com/gbraad> agreed! Hence the change which
@cfergeau <https://github.com/cfergeau> suggests makes sense to align the
messages. And the message about stopping should also be changed since we're
at it - I think. The output currently is:
Stopping the OpenShift cluster, this may take a few minutes...
The OpenShift cluster stopped
The first line suggests that something/someone is stopping the cluster,
while the second line suggests that the cluster stopped itself. It'd be
better if the second line was The OpenShift cluster was stopped. And this
would go well with the The OpenShift cluster was deleted that Christophe
suggests, and with The Openshift cluster is running that start prints.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#760>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAOZXO56FAOCWMVKJJSITQQFJAPANCNFSM4JD5RABQ>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
I disagree. The difference is analogous to Anyway, I don't mind either way. Just wanted to say that on top of what @cfergeau suggested, there is also the output of |
|
In this case there is no other party involved. We refer to the action as
performed by CRC
Also, we avoid talking as an intermediary is used, such as the hypervisor.
…On Thu, Oct 24, 2019 at 4:30 PM jakub sliacan ***@***.***> wrote:
Was stopped is an unnecessary addition to indicate that the action
happened.
I disagree. The difference is analogous to I was tripped vs I tripped.
The former was done by an external agent, in the latter one I was the
agent. In our messages, we are mixing these two (passive & active forms).
Anyway, I don't mind either way. Just wanted to say that on top of what
@cfergeau <https://github.com/cfergeau> suggested, there is also the
output of crc stop to look at. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#760>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAOZXFAOPRLIP4CU2ZOELQQFMLJANCNFSM4JD5RABQ>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
|
I also feel 'was stopped' is better than 'stopped', but I'll just agree with anything @robin-owen suggests :) |
|
This was part of the PR both I and Kevin reviewed:
https://github.com/code-ready/crc/pull/715/files#diff-bbce5b71f054417979338a1d660c6c12R49 (Issue #714)
|
|
Yeah, sorry I missed it when that was happening! Btw, there's a typo in one of the changes introduced there ( Just leaving it here to go in with any other changes. |
|
It was a very large changeset and communicated several times :-/
Changing strings after release is more difficult, as people might have a
script or CI that checks these messages.
Typos should really be changed. but what can be avoided, should be
considered and weighed.
Note: this was very close to release and mentioned very times on
the internal slack addressing the whole team, due to the importance
and impact. I understood the complaints it was difficult as this was
a very large change, but I am glad it happened. It had a strict deadline
due to the release.
|
Fwiw, the real solution for that is to prioritize -o json for all commands, not to have a hard freeze on what we output. |
|
"Deleted the OpenShift cluster" would be an active way of phrasing this. |
this is going to be worked on soon-ish. Note: but do we really need any confirmation for the delete? I never seen |
Right. The passive voice is not wanted here. ... however, is a message needed? In case of an error perhaps, but when confirmation is asked, and nothing fails, you expect this to have happened. Right? |
Was the cluster fully stopped, or was the warning fatal? An explicit message avoids this kind of questions. |
"The OpenShift cluster deleted" was not correct, it was suggested to use the active voice instead "Deleted the OpenShift cluster" This fixes crc-org#760
"The OpenShift cluster deleted" was not correct, it was suggested to use the active voice instead "Deleted the OpenShift cluster" This fixes crc-org#760
"The OpenShift cluster deleted" was not correct, it was suggested to use the active voice instead "Deleted the OpenShift cluster" This fixes crc-org#760
After successfully running
crc delete,The OpenShift cluster deletedis displayed. This looks like it's missingwas.The text was updated successfully, but these errors were encountered: