Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tagged image for recovery process instead fetching from internet #840

Closed
praveenkumar opened this issue Nov 26, 2019 · 2 comments
Closed

Use tagged image for recovery process instead fetching from internet #840

praveenkumar opened this issue Nov 26, 2019 · 2 comments

Comments

@praveenkumar
Copy link
Member

Right now https://github.com/code-ready/crc/blob/master/pkg/crc/machine/cert-renewal.go#L66-L77 we are trying to fetch the image content from internet but since crc-org/snc#132 is in and we already tag that image so we don't need to fetch it from internet anymore.
@praveenkumar praveenkumar added kind/bug Something isn't working and removed kind/bug Something isn't working labels Nov 26, 2019
@praveenkumar praveenkumar changed the title [BUG] Use tagged image for recovery process instead fetching from internet Use tagged image for recovery process instead fetching from internet Nov 26, 2019
@cfergeau
Copy link
Contributor

kaoImage := "openshift/cert-recovery" should do the trick.

praveenkumar added a commit that referenced this issue Nov 28, 2019
@praveenkumar
Issue #840 Use tagged image instead of fetching from registry
8b3fe03 
We already tag cluster kube-apiserver-operator image as part of our
bundle generation script. Using the tag is going to avoid fetching
the image details from quay registry instead directly use of this tag.

- crc-org/snc@de4ccd5
@praveenkumar
Copy link
Member Author

Fixed by #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@praveenkumar @cfergeau