Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host->cluster DNS checks #854

Closed
2 tasks
cfergeau opened this issue Nov 28, 2019 · 4 comments · Fixed by #922
Closed
2 tasks

Add host->cluster DNS checks #854

cfergeau opened this issue Nov 28, 2019 · 4 comments · Fixed by #922
Projects
Sprint 177 Sprint 178

Comments

@cfergeau
Copy link
Contributor

cfergeau commented Nov 28, 2019 •
edited by gbraad

At the moment we check VM->cluster DNS, VM->external DNS, but I could not find a startup check that the host can resolve api.crc.testing and non-existing-app.apps-crc.testing after the dnsmasq container was started.
We should add such a check, and verify that it matches the VM IP. Not sure whether this should abort crc start or just be a warning though.

  • check api.crc.testing
  • check foo.crc-apps.testing
@cfergeau cfergeau mentioned this issue Dec 9, 2019
Merged
praveenkumar added a commit that referenced this issue Dec 12, 2019
@praveenkumar
Issue #854 Add host->cluster DNS checks
e3ad198 
This check will make sure that host can able to resolve the dns
for api and app domain of crc using dnsmasq which is running
inside the VM.
praveenkumar added a commit that referenced this issue Dec 16, 2019
@praveenkumar
Revert "Issue #854 Add host->cluster DNS checks"
2985be8 
Since this commit adds regression for macos because of mac
resolver doesn't allow to resolve from `/etc/resolver/testing`
if cross build binary is in used and failed to resolve
`foo.apps-crc.testing`.

This reverts commit e3ad198.
praveenkumar added a commit that referenced this issue Dec 16, 2019
@praveenkumar
Revert "Issue #854 Add host->cluster DNS checks"
0cdc12b 
Since this commit adds regression for macos because of mac
resolver doesn't allow to resolve from `/etc/resolver/testing`
if cross build binary is in used and failed to resolve
`foo.apps-crc.testing`.

This reverts commit e3ad198.
@gbraad
Copy link
Contributor

gbraad commented Dec 16, 2019

Unfortunately this check has been reverted.

@gbraad gbraad added this to To do in Sprint 177 Dec 17, 2019
@gbraad gbraad moved this from To do to Done in Sprint 177 Dec 17, 2019
@cfergeau cfergeau moved this from Done to To do in Sprint 177 Dec 17, 2019
@cfergeau cfergeau mentioned this issue Dec 20, 2019
Closed
@cfergeau
Copy link
Contributor Author

This was reverted because of #893
Since our builds have CGO_ENABLED=0, the binary does not make use of /etc/resolver/ for DNS resolution, but relies on hardcoded entries in /etc/hosts, so checking for foo.crc.testing fails.

@gbraad gbraad added this to To do in Sprint 178 Jan 7, 2020
@cfergeau cfergeau mentioned this issue Jan 7, 2020
Closed
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 7, 2020

As indicated in #918, for now we could have a check for only api.crc.testing.
Regarding the check for foo.crc-apps.testing, we can do it only on linux/windows to avoid the issue we have on macos

cfergeau added a commit to cfergeau/crc that referenced this issue Jan 7, 2020
@cfergeau
Issue crc-org#854 Add host->cluster DNS checks
bbe3ca9 
This check will make sure that host can able to resolve the dns
for api and app domain of crc using dnsmasq which is running
inside the VM.

This patch is heavily based on a patch from Praveen Kumar
<kumarpraveen.nitdgp@gmail.com>, with the addition of the code excluding macos
from the apps domain check.

This fixes crc-org#854
@gbraad
Copy link
Contributor

gbraad commented Jan 7, 2020

See first message

@cfergeau cfergeau mentioned this issue Jan 7, 2020
Merged
@cfergeau cfergeau moved this from To do to In progress in Sprint 178 Jan 7, 2020
praveenkumar pushed a commit that referenced this issue Jan 9, 2020
@cfergeau @praveenkumar
Issue #854 Add host->cluster DNS checks
6673ade 
This check will make sure that host can able to resolve the dns
for api and app domain of crc using dnsmasq which is running
inside the VM.

This patch is heavily based on a patch from Praveen Kumar
<kumarpraveen.nitdgp@gmail.com>, with the addition of the code excluding macos
from the apps domain check.

This fixes #854
@gbraad gbraad moved this from In progress to Done in Sprint 178 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sprint 177
  
To do
Sprint 178
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #854 Add host->cluster DNS checks cfergeau/crc
2 participants
@gbraad @cfergeau