Issue #1147 Move docs modules to accessible directory #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per modular documentation guidelines, modules should exist in an accessible location for potential use in multiple guides.
cfergeau
reviewed
Apr 9, 2020
| @@ -20,22 +20,22 @@ For more information, see <<configuring-the-virtual-machine_{context}>>. | |||
|
|
|||
| ** On Linux or {mac}: | |||
| + | |||
| [subs="+quotes,attributes"] | |||
| [subs="+quotes"] | |||
There was a problem hiding this comment.
These ",attributes" removals seem unrelated, are they intentional?
There was a problem hiding this comment.
Yes, they're intentional, but only because I happened to notice them while building the docs to test how they build with the modules moved around.
The inclusion of "attributes" here causes warnings while building the docs about undefined attributes (the {end} portions of the source blocks are interpreted as attributes by AsciiDoctor).
I can move these changes into their own dedicated commit if you'd prefer.
There was a problem hiding this comment.
I don't feel that strongly about the separate commit (even if that's better ;), I wanted to make sure this was not an oversight.
cfergeau
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per modular documentation guidelines, modules should exist in an
accessible location for potential use in multiple guides.
Fixes: Issue #1147