Use ad-hoc signing on macOS, and bump minimum libvirt version #4048
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When there is no signing identity to pass to the macOS `codesign` tool, we can use `-` instead as the identity to perform ad-hoc signing. From `man codesign`: > If identity is the single letter "-" (dash), ad-hoc signing is > performed. Ad-hoc signing does not use an identity at all This makes it easier to test the sign() code-path in package.sh as we'll run the same code regardless of `NO_CODESIGN` being set or not. This matches what was done in containers/podman@74b87874b63942 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
machine-driver-libvirt was recently switched to 8.0.0: crc-org/machine-driver-libvirt@bd62139 This fixes crc-org#4047 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
cfergeau
force-pushed
the
macos-signing
branch
from
6775366
to
295fc22
Compare
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 unrelated commits in this PR, one to sync our macOS signing code with podman, and the other to bump the minimum libvirt version we require after the libvirt-machine-driver update.