Add debug logs for windows preflight checks and setup #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
requested changes
Oct 23, 2019
| yourWindowsReleaseId, err := strconv.Atoi(strings.TrimSpace(stdOut)) | ||
|
|
||
| if err != nil { | ||
| logging.Debug(err.Error()) | ||
| return false, errors.New("Failed to get Windows release id") |
There was a problem hiding this comment.
This is exactly the same error returned in this case and before, which could make it harder to figure out which of the 2 functions failed. This one could be changed to "Failed to parse Windows release id: %s", stdOut
|
|
cfergeau
reviewed
Oct 31, 2019
| stdOut, _, err := powershell.Execute(checkIfMemberOfHyperVAdmins) | ||
| if err != nil { | ||
| logging.Debug(err.Error()) | ||
| return false, errors.New("Failed checking if user is part of hyperv admins group") |
There was a problem hiding this comment.
Did you check preflight on Windows after these changes? I wonder if we get an error when user is not a member of the admin group, or just regular output from the command?
|
You did see #777? |
… in PATH if exec.LookPath can't find the location of powershell.exe we fall back to using C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
Also add more debug logs to windows preflight checks and setup
|
retest this please |
gbraad
approved these changes
Nov 1, 2019
|
We might have to add some minor improvements, as we now assume the
stdLocation exists and has an executable. if this is not the case the error
will follow in the first use instead. this is not a big issue, but could be
nicer. for future when this actually happens in the field
…On Fri, Nov 1, 2019 at 7:33 PM Praveen Kumar ***@***.***> wrote:
Merged #761 <#761> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#761>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAOZQQB2SC4IN5MTE2CXLQRQHXFANCNFSM4JD7VQVA>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also as suggested added a fall-back location for Powershell, in case it is not it path.
Fixes #753