Update proc_starting-the-virtual-machine.adoc #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Note to setup instructions to account for problem such as "Bundle 'crc_hyperkit_4.2.8.crcbundle' was requested, but the existing VM is using 'crc_hyperkit_4.2.2.crcbundle'"
|
Can one of the admins verify this patch? |
gbraad
requested changes
Dec 9, 2019
docs/source/getting-started/content/proc_starting-the-virtual-machine.adoc
Outdated
Show resolved
Hide resolved
Revised note to generalize for dependency mismatch
cfergeau
reviewed
Dec 10, 2019
docs/source/getting-started/content/proc_starting-the-virtual-machine.adoc
Outdated
Show resolved
Hide resolved
created specific troubleshooting section for bundle version error
added new troubleshooting topic on bundle version mismatch
Revised note on error on start.
Added note on the need to capture any changes made to the instances
kowen-rh
suggested changes
Dec 18, 2019
docs/source/getting-started/content/proc_starting-the-virtual-machine.adoc
Outdated
Show resolved
Hide resolved
| [id="troubleshooting-bundle-version-mismatch_{context}"] | ||
| = Troubleshooting bundle version mismatch | ||
|
|
||
| As {prod} releases are setup and started, instances are created with bundle information |
There was a problem hiding this comment.
"set up" instead of "setup". This applies generally.
Also, could you please keep each sentence on its own line? We don't particularly care about the line length, but want to keep each sentence isolated so that diffs are cleaner. :)
docs/source/getting-started/content/proc_troubleshooting-bundle-version-mismatch.adoc
Show resolved
Hide resolved
docs/source/getting-started/content/proc_troubleshooting-bundle-version-mismatch.adoc
Outdated
Show resolved
Hide resolved
|
https://github.com/cfergeau/crc/commits/pr871 should have the changes requested by @robin-owen |
kowen-rh
suggested changes
Jan 13, 2020
docs/source/getting-started/content/proc_troubleshooting-bundle-version-mismatch.adoc
Outdated
Show resolved
Hide resolved
docs/source/getting-started/content/proc_troubleshooting-bundle-version-mismatch.adoc
Outdated
Show resolved
Hide resolved
separated sentences into separate lines
kowen-rh
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #870
added Note to setup instructions to account for problem such as "Bundle 'crc_hyperkit_4.2.8.crcbundle' was requested, but the existing VM is using 'crc_hyperkit_4.2.2.crcbundle'"