Issue #929: logging: Ensure ~/.crc exists before creating log file #932
Conversation
…file crc-embedder currently fails if ~/.crc does not exist. This is because it tries to create a log file before ~/.crc is created. Adding a call to EnsureBaseDirExists() before trying to create the log file fixes this issue. This fixes crc-org#929
|
retest this please. |
| err := constants.EnsureBaseDirExists() | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
@cfergeau This should be part of crc-embedder/root.go script instead here, same way it is part of crc/root.go because it is not only creating the log directory but initial structure so should be part of init method of root.
There was a problem hiding this comment.
With Anjan's refactor of this code, we can move the responsibility of creating the directories to the caller.
With the current code, where it's pkg/crc/logging/logging.go which decides where to put its log file, to me it makes sense that it also makes sure the directory exists.
There was a problem hiding this comment.
Yes, this one. Currently, where the log is stored is an implementation detail of the 'logging' package, so in my opinion it makes sense that the logging package takes care of creating the path.
After Anjan's refactor, where the log is stored is specified by users of the package iirc. The location of the log file is no longer internal to the logging package, so it makes sense that users of logging are required to make sure the path exists.
crc-embedder currently fails if ~/.crc does not exist. This is because
it tries to create a log file before ~/.crc is created. Adding a call to
EnsureBaseDirExists() before trying to create the log file fixes this
issue.
This fixes #929