set no proxy environment variable properly in kubelet and crio #945

opuk · 2020-01-21T13:28:42Z

the NO_PROXY variable was incorrectly set, this should fix this

$ cat /etc/systemd/system/crio.service.d/10-default-env.conf
[Service]
Environment=HTTP_PROXY=http://10.3.0.2:8118
Environment=HTTPS_PROXY=http://10.3.0.2:8118
Environment=NO_PROXY=.cluster.local,.svc,10.128.0.0/14,172.30.0.0/16,[127.0.0.1 localhost .testing 192.168.64.2]

centos-ci · 2020-01-21T13:28:43Z

Can one of the admins verify this patch?

praveenkumar · 2020-01-21T13:30:44Z

pkg/crc/cluster/cluster.go

@@ -163,8 +163,7 @@ func AddProxyToKubeletAndCriO(sshRunner *ssh.SSHRunner, proxy *network.ProxyConf
 Environment=HTTP_PROXY=%s
 Environment=HTTPS_PROXY=%s
 Environment=NO_PROXY=.cluster.local,.svc,10.128.0.0/14,172.30.0.0/16,%s`
-
-	p := fmt.Sprintf(proxyTemplate, proxy.HttpProxy, proxy.HttpsProxy, proxy.NoProxy)
+	p := fmt.Sprintf(proxyTemplate, proxy.HttpProxy, proxy.HttpsProxy, strings.Join(proxy.NoProxy, ","))


praveenkumar · 2020-01-21T13:31:07Z

ok to test

set no proxy environment variable properly in kubelet and crio

4007eda

praveenkumar reviewed Jan 21, 2020

View reviewed changes

praveenkumar merged commit 35e214f into crc-org:master Jan 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set no proxy environment variable properly in kubelet and crio #945

set no proxy environment variable properly in kubelet and crio #945

opuk commented Jan 21, 2020

centos-ci commented Jan 21, 2020

praveenkumar Jan 21, 2020

praveenkumar commented Jan 21, 2020

set no proxy environment variable properly in kubelet and crio #945

set no proxy environment variable properly in kubelet and crio #945

Conversation

opuk commented Jan 21, 2020

centos-ci commented Jan 21, 2020

praveenkumar Jan 21, 2020

Choose a reason for hiding this comment

praveenkumar commented Jan 21, 2020