Update oc binary download url for arm64 binary #846
Conversation
Looks like there is confusion around the oc download path url to grab platfrom specific binary. Ideally if we use arch specific url to download the oc binary it should have by default for that specific org which is not the case so need to explicit specify the arch info in the url. - https://issues.redhat.com/browse/OCPBUGS-28720
|
Only did for mac because that only the bundle we support for CRC side on arm64 arch. |
| curl -L "${MIRROR}/${OPENSHIFT_RELEASE_VERSION}/openshift-client-mac-${yq_ARCH}-${OPENSHIFT_RELEASE_VERSION}.tar.gz" | tar -zx -C openshift-clients/mac oc | ||
| else | ||
| curl -L "${MIRROR}/${OPENSHIFT_RELEASE_VERSION}/openshift-client-mac-${OPENSHIFT_RELEASE_VERSION}.tar.gz" | tar -zx -C openshift-clients/mac oc | ||
| fi |
There was a problem hiding this comment.
Having a check that the oc binary matches what we expect (darwin/linux/windows x86_64/arm64) could be useful to avoid such issues in the future?
There was a problem hiding this comment.
@cfergeau you mean kind of run file command and see if it contain the arch which we expect?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.15 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.15 |
|
@praveenkumar: new pull request created: #848 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@praveenkumar: new pull request could not be created: failed to create pull request against crc-org/snc#release-4.15 from head openshift-cherrypick-robot:cherry-pick-846-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-846-to-release-4.15."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like there is confusion around the oc download path url to grab platfrom specific binary. Ideally if we use arch specific url to download the oc binary it should have by default for that specific org which is not the case so need to explicit specify the arch info in the url.