Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and mirror for master #858

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

praveenkumar
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from anjannath and gbraad March 4, 2024 09:10
README.md Outdated
## How to use?
- Make sure the one time setup is satisfied. (https://github.com/openshift/installer/blob/master/docs/dev/libvirt/README.md#one-time-setup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could go in the PR removing qemu+tcp

README.md Outdated
@@ -1,14 +1,14 @@
# Single node cluster (snc) scripts for OpenShift 4

**NOTE:** Please select respective branch to create the bundle for specific openshift release (ie. to create 4.15.x openshift bundle choose `release-4.15` branch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please select the respective branche to create a bundle for a specific OpenShift release (ie. to create a 4.15.x OpenShift bundle, choose the release-4.15 branch)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a before specific.

README.md Show resolved Hide resolved
Copy link
Collaborator

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor grammatical change

- Remove old assumptions which used for libvirt IPI
- Add note around how to consume the branch
Since we want master branch to be sync with what is upcoming openshift release,
this pr update the mirror url and release.txt fetch path to have always
latest candidate for releases.

- https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp-dev-preview/candidate/
This is required for marketplace capability and need to be enabled if
marketplace is enabled.

- https://pkg.go.dev/github.com/openshift/api/config/v1#ClusterVersionCapability
( ClusterVersionCapabilityMarketplace section)

It also fix following error from CI
```
level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: additionalEnabledCapabilities: Invalid value: []v1.ClusterVersionCapability{"openshift-samples", "marketplace", "Console", "MachineAPI", "ImageRegistry", "DeploymentConfig", "Build"}: the marketplace capability requires the OperatorLifecycleManager capability
```
Copy link

openshift-ci bot commented Mar 4, 2024

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift b533972 link true /test e2e-microshift
ci/prow/e2e-snc b533972 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

But I don't know if the 3rd commit " Install-config: Enable OperatorLifecycleManager capability" is still relevant?

Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar
Copy link
Member Author

/approve /lgtm

But I don't know if the 3rd commit " Install-config: Enable OperatorLifecycleManager capability" is still relevant?

Yes it is still relevant.

@praveenkumar praveenkumar merged commit 094108b into crc-org:master Mar 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants