Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No CGO for rest consumers/clients #51

Closed
wants to merge 1 commit into from
Closed

No CGO for rest consumers/clients #51

wants to merge 1 commit into from

Conversation

baude
Copy link
Collaborator

@baude baude commented Jul 7, 2023

Refactored portions of the rest code to not require CGO for rest consumers. Most of the refactored code was moved into pkg/rest/define to isolate it.

Also pruned an unused function and related unit test.

@baude
No CGO for rest consumers/clients
634667a 
Refactored portions of the rest code to not require CGO for rest consumers.  Most of the refactored code was moved into pkg/rest/define to isolate it.

Also pruned an unused function and related unit test.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@gbraad gbraad requested review from gbraad and cfergeau July 10, 2023 05:31
@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbraad
Once this PR has been reviewed and has the lgtm label, please ask for approval from baude. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Collaborator

An alternative would be to use interfaces to separate the code-hex/vz code from the rest code, I tried this in cfergeau@c395103

@baude
Copy link
Collaborator Author

baude commented Jul 10, 2023

closing in favor of #52

@baude baude closed this Jul 10, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbraad gbraad gbraad approved these changes

@anjannath anjannath Awaiting requested review from anjannath

@praveenkumar praveenkumar Awaiting requested review from praveenkumar

@cfergeau cfergeau Awaiting requested review from cfergeau

Assignees

@gbraad gbraad

Labels
lgtm needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baude @cfergeau @openshift-merge-robot @gbraad