fix: Objects with special symbols in primary key 404-ed #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachch
changed the title
crccheck
changed the title
crccheck
approved these changes
Aug 8, 2020
|
I think it's finished - I tested it locally, so it works as expected And I will be very grateful if this will apper in pypi |
crccheck
approved these changes
Aug 9, 2020
|
k. released as v3.0.1 |
|
thank you for releasing it so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for case if object in database has any of special symbols
https://github.com/django/django/blob/master/django/contrib/admin/utils.py#L17
clicking on action button causes 404 error, as in SingleObjectMixin there are already parsed kwargs from url, and they are unquoted
made unquoting kwargs