Skip to content

Commit

Permalink
feat: update dev dependencies (#46)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: drops support for Node 6 and Node 8

Since the actual dependencies haven't been changed, it will probably still work for older Node versions, but the test suite won't support them anymore.
  • Loading branch information
crccheck committed Jan 13, 2020
1 parent 60b18aa commit 2e81366
Show file tree
Hide file tree
Showing 6 changed files with 2,082 additions and 2,849 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: node_js
node_js:
- "6"
- "8"
- "10"
- "12"
before_script:
- npm install coveralls mocha-lcov-reporter
script: npm run test
Expand Down
2 changes: 1 addition & 1 deletion cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ if (!program.args.length) {
.catch(console.error)
}

updateNotifier({pkg}).notify()
updateNotifier({ pkg }).notify()
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class KinesisStreamReader extends Readable {
const whitelist = ['ShardIteratorType', 'Timestamp', 'StartingSequenceNumber']
const shardIteratorOptions = Object.keys(this.options)
.filter((x) => whitelist.indexOf(x) !== -1)
.reduce((result, key) => Object.assign(result, {[key]: this.options[key]}), {})
.reduce((result, key) => Object.assign(result, { [key]: this.options[key] }), {})
return getShardId(this.client, this.streamName)
.then((shardIds) => {
const shardIterators = shardIds.map((shardId) =>
Expand Down Expand Up @@ -91,7 +91,7 @@ class KinesisStreamReader extends Readable {
data.Records.forEach((x) => {
let record = this.options.parser(x.Data)
if (this.options.unzip) {
record = zlib.gunzipSync(Buffer.from(record, 'base64')).toString()
record = zlib.gunzipSync(Buffer.from(record, 'base64')).toString()
}
if (this.options.newLine) {
record += '\n'
Expand Down
Loading

0 comments on commit 2e81366

Please sign in to comment.