PixelPropUtils: Fix GMS drain triggered by an outdated ROM build date #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the build date exceeds a month, GMS, thinking the device is Pixel, attempts a system update, which unexpectedly fails. This goes into an endless cycle which drains battery very quickly and generates a lot of heat. Let's fix it by spoofing the build date to something always fresh.
| @@ -272,6 +272,7 @@ public static void setProps(String packageName) { | |||
| setPropValue(key, value); | |||
| } | |||
| if (packageName.equals("com.google.android.gms")) { | |||
| setPropValue("TIME", System.currentTimeMillis()); | |||
There was a problem hiding this comment.
Move it to spoofBuildGms().
There was a problem hiding this comment.
It's there where it should be. It's not specific to SafetyNet, but to GMS in general. The draining thread INSTALL_UPDATE runs in 'com.google.android.gms' process.
|
Could this maybe get a bit more attention? I see the useless pixel system update very often as well in the last time. |
|
Thanks😊 |
Could you tell me if this actually fixes your issues on the F3 |
|
Yes I will, when @raystef66 releases a new ROM for our device, I will come back again. |
Terminator-J
added a commit
to Terminator-J/crdroid_frameworks_base
that referenced
this pull request
Jan 11, 2024
The now-squashed commit "PixelPropsUtils: Allow devices to opt out gms/gapps" crdroidandroid@8baa018 changed behavior to actually require explicitly setting props to true. Change logic to function the way it did before for this block of functions, and allow automatically benefiting from SPOOF_PIXEL_GMS (like avoiding GMS battery drain when Pixel udate is available but device has not been updated to new ASB yet, see crdroidandroid#1026 ) and require explicit commits by maintainers to opt-out per device.
Terminator-J
added a commit
to Terminator-J/crdroid_frameworks_base
that referenced
this pull request
Jan 13, 2024
The now-squashed commit "PixelPropsUtils: Allow devices to opt out gms/gapps" crdroidandroid@8baa018 changed behavior to actually require explicitly setting props to true. Change logic to function the way it did before for this block of functions, and allow automatically benefiting from SPOOF_PIXEL_GMS (like avoiding GMS battery drain when Pixel udate is available but device has not been updated to new ASB yet, see crdroidandroid#1026 ) and require explicit commits by maintainers to opt-out per device.
Terminator-J
added a commit
to Terminator-J/crdroid_frameworks_base
that referenced
this pull request
Jan 13, 2024
The now-squashed commit "PixelPropsUtils: Allow devices to opt out gms/gapps" crdroidandroid@8baa018 changed behavior to actually require explicitly setting props to true. Change logic to function the way it did before for this block of functions, and allow automatically benefiting from SPOOF_PIXEL_GMS (like avoiding GMS battery drain when Pixel udate is available but device has not been updated to new ASB yet, see crdroidandroid#1026 ) and require explicit commits by maintainers to opt-out per device.
Terminator-J
added a commit
to Terminator-J/crdroid_frameworks_base
that referenced
this pull request
Jan 14, 2024
The now-squashed commit "PixelPropsUtils: Allow devices to opt out gms/gapps" crdroidandroid@8baa018 changed behavior to actually require explicitly setting props to true. Change logic to function the way it did before for this block of functions, and allow automatically benefiting from SPOOF_PIXEL_GMS (like avoiding GMS battery drain when Pixel udate is available but device has not been updated to new ASB yet, see crdroidandroid#1026 ) and require explicit commits by maintainers to opt-out per device.
Terminator-J
added a commit
to Terminator-J/crdroid_frameworks_base
that referenced
this pull request
Jan 14, 2024
The now-squashed commit "PixelPropsUtils: Allow devices to opt out gms/gapps" crdroidandroid@8baa018 changed behavior to actually require explicitly setting props to true. Change logic to function the way it did before for this block of functions, and allow automatically benefiting from SPOOF_PIXEL_GMS (like avoiding GMS battery drain when Pixel udate is available but device has not been updated to new ASB yet, see crdroidandroid#1026 ) and require explicit commits by maintainers to opt-out per device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the build date exceeds a month, GMS, thinking the device is Pixel, attempts a system update, which unexpectedly fails. This goes into an endless cycle, which drains battery very quickly and generates a lot of heat. Let's fix it by spoofing the build date to something always fresh.