Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US6646 - Add footer to DDK #40

Closed
wants to merge 17 commits into from

Conversation

seancdavis
Copy link
Contributor

Given a designer/developer using the DDK
When I need to reference styles for the cr.net footer
Then I should find the markup within the molecules section of the DDK that matches the reskin


Connected to crdschurch/crds-styleguide#52 and crdschurch/SS-CMS#48.

@seancdavis
Copy link
Contributor Author

@tcmacdonald: Not sure how I troubleshoot failing builds.

Add back the circular reference
.square-corners {
border-radius: 0;
}

.circular {
border-radius: 100%;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an instance where I've added a utility so it could be used elsewhere. In cases like this, should I also be documenting this in the DDK?

Mustache template supports colors using masks and a key map for color vars
Regenerate SVG sprite using new template and add circle icon
Support circular icon stacks
Support classes to change icon colors on stack hover
Size fix for icon stacks
@seancdavis
Copy link
Contributor Author

seancdavis commented Feb 24, 2017

@tcmacdonald: This is ready for another review, but I have a few concerns/issues:

  1. The suggestion on coloring SVGs wouldn't work as you described here when using the i or .icon approach because they aren't treated as SVGs, but as background images.

    The best way I could get around this was to use masks, which I'm now thinking isn't a good approach. Otherwise, this may require a more in-depth discussion about SVG implementation strategies to be able to adjust color easily. (I feel like we're going to want the i or .icon approach.)

  2. There were a few times where I used i.icon to be the higher specificity. That feels too rigid, but I also don't like using !important when I don't have to.

  3. I moved the colors into a map so we can iterate through them and write cleaner Sass when we have color variations. Ultimately what I'd like to do is make this map nested so that the light and dark variations on a particular hue are nested in a second level, giving you more flexibility to use only the main colors and skip the variations.

    That being said, the downside to this is that Sass does not have an instance_variable_set sort of function, so now when we define a color, we have to add its associated variable to the bottom of the variables partial.

  4. I'm now getting those dang lines underneath the icons at their smallest sizes. Not sure this was happening before. But this may not matter as much if we are going to ditch masks.

@tcmacdonald tcmacdonald closed this Mar 3, 2017
@tcmacdonald tcmacdonald deleted the feature/US6646-add-footer-to-ddk branch November 10, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants