-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US6646 - Add footer to DDK #40
Conversation
add basic footer styles
Simplify footer styles and create social icons
Put back unused styles
@tcmacdonald: Not sure how I troubleshoot failing builds. |
Add back the circular reference
.square-corners { | ||
border-radius: 0; | ||
} | ||
|
||
.circular { | ||
border-radius: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an instance where I've added a utility so it could be used elsewhere. In cases like this, should I also be documenting this in the DDK?
Mustache template supports colors using masks and a key map for color vars
Regenerate SVG sprite using new template and add circle icon
Support circular icon stacks
Support classes to change icon colors on stack hover
Size fix for icon stacks
@tcmacdonald: This is ready for another review, but I have a few concerns/issues:
|
Add icon font as a backup
Undo icon font
Put color variables back
Add cr-white option for svg icons
Adjust how we use create circle icons
Given a designer/developer using the DDK
When I need to reference styles for the cr.net footer
Then I should find the markup within the molecules section of the DDK that matches the reskin
Connected to crdschurch/crds-styleguide#52 and crdschurch/SS-CMS#48.