Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove-mailcatcher: Gemfile から mailcatcher を削除した #116

Merged
merged 3 commits into from
Nov 1, 2018
Merged

remove-mailcatcher: Gemfile から mailcatcher を削除した #116

merged 3 commits into from
Nov 1, 2018

Conversation

koi-chan
Copy link
Member

issue: #112

@koi-chan koi-chan self-assigned this Oct 24, 2018
@ochaochaocha3 ochaochaocha3 mentioned this pull request Nov 1, 2018
Merged
ochaochaocha3
ochaochaocha3 approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。テスト時のみ関係するので、問題ないと思います。

mailcatcherの説明に、「READMEにmailcatcherのインストールについて注記してください」と書かれていたので、PR #118 でREADMEにその旨を追記しました。こちらの確認をお願いいたします。

@ochaochaocha3
Merge pull request #118 from cre-ne-jp/remove-mailcatcher-readme
115d54a 
remove-mailcatcher: README: mailcatcherのインストールについて追記する
@ochaochaocha3 ochaochaocha3 merged commit d6f3194 into master Nov 1, 2018
@koi-chan koi-chan deleted the remove-mailcatcher branch November 1, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochaochaocha3 ochaochaocha3 ochaochaocha3 approved these changes

Assignees

@koi-chan koi-chan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koi-chan @ochaochaocha3