Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bcdice: テストに失敗するようになったのを修正 #161

Conversation

koi-chan
Copy link
Member

fix #154

アダプタ側でのジェネレータ読み込み方法を改善しました。
テストでの処理が複雑化してしまっていますが、他の何か良い方法はあるでしょうか。

@koi-chan koi-chan self-assigned this Jul 27, 2019
@ochaochaocha3
Copy link
Member

#162 で、テストを簡潔に書けるようにしてみました。ご確認よろしくお願いします。

…module_fix_bcdice_test-init_instance_var

BCDice: コンストラクタでBCDiceを用意する
@ochaochaocha3
Copy link
Member

#162 をマージしたので、こちらもマージいたします。

@ochaochaocha3 ochaochaocha3 merged commit 0095727 into arrange-plugin-adapter-module Jul 28, 2019
@koi-chan koi-chan deleted the arrange-plugin-adapter-module_fix_bcdice_test branch July 30, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants