Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRC 版のプラグイン Ctcp を修正 #173

Merged
merged 6 commits into from
Sep 26, 2019
Merged

IRC 版のプラグイン Ctcp を修正 #173

merged 6 commits into from
Sep 26, 2019

Conversation

koi-chan
Copy link
Member

@koi-chan koi-chan commented Sep 26, 2019 •
edited
Loading

@koi-chan koi-chan self-assigned this Sep 26, 2019
@ochaochaocha3
CTCP: TIMEの応答をRFC 2822形式で返す
25a3145 
strftimeの部分を簡潔に書く
@ochaochaocha3
利用可能なCTCPコマンドをクラス定数で定義する
40a26f9 
一箇所で定義して漏れが発生しないようにする
@ochaochaocha3
CTCP: コメントを追加する
4de0ca5 
RFCのドラフトにおける各コマンドの説明のURLを追加したかった
@ochaochaocha3 ochaochaocha3 mentioned this pull request Sep 26, 2019
Merged
@ochaochaocha3
Copy link
Member

PR #174 と #175 でさらに案を示しました。ご確認よろしくお願いします。

@ochaochaocha3
Merge pull request #175 from cre-ne-jp/ctcp-available_commands
c8d9445 
CTCP: コマンド一覧の改良とコメントの追加
@ochaochaocha3
Merge pull request #174 from cre-ne-jp/ctcp-time_rfc2822
3e7689b 
CTCP: TIMEの応答をRFC 2822形式で返す
ochaochaocha3
ochaochaocha3 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです！

@ochaochaocha3 ochaochaocha3 merged commit ed0e8f5 into master Sep 26, 2019
@koi-chan koi-chan deleted the fix-ctcp-plugin branch September 26, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochaochaocha3 ochaochaocha3 ochaochaocha3 approved these changes

Assignees

@koi-chan koi-chan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctcp: 入力・出力をログに残す
2 participants
@koi-chan @ochaochaocha3