build fixes for perl 5.37.8 and some other historic nits #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, if i were you i would reconsider using Dist::Zilla. I know @avar liked it, but it makes supporting this module when the regex engine changes very difficult. It would be nice if you ditched it and switched to EUMM which builds nice and clean without taking over an hour to install the dependencies required just to run dzil build. There are likely more breaking changes coming, and it would be nice not to have to go through that again. See: Perl/perl5#20710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the module to compile without warnings or test failures on 5.37.8