Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge StackedCoordinates and DependentCoordinates #268

Closed
jmilloy opened this issue May 8, 2019 · 3 comments
Closed

Merge StackedCoordinates and DependentCoordinates #268

jmilloy opened this issue May 8, 2019 · 3 comments
Assignees
Labels

Comments

@jmilloy
Copy link
Collaborator

jmilloy commented May 8, 2019

Description

The DependentCoordinates are a generalization of StackedCoordinates that supports N-dimensional stacked coordinate arrays. It is confusing to have both, and also to have both the lat_lon and lat,lon dimension names.

The DependentCoordinates takes a list of numpy arrays, whereas the StackedCoordinates takes a list of Coordinates1d objects, so that needs to be sorted out as well.

Note also that ArrayCoordinatesNd is a direct generalization of ArrayCoordinates1d, so ArrayCoordinates1d should probably be removed/replaced as well.

Proposal

I would use ArrayCoordinatesNd directly in the DependentCoordinates (instead of a numpy array). UnformCoordinates1d would need a generalized version as well, and if we use N-dimeesional origin, corner, step, and shape traits/properties, that will correspond well with RotatedCoordinates. The clinspace spec would need to be modified, too.

And then I think we should rename DependentCoordinates to StackedCoordinates (and remove the current StackedCoordinates).

I don't think it matters to me whether we use lat_lon or lat,lon as the dimension name.

@jmilloy jmilloy self-assigned this May 8, 2019
@jmilloy
Copy link
Collaborator Author

jmilloy commented May 8, 2019

@mlshapiro @mpu-creare We've both discussed this at some point.

@mpu-creare mpu-creare added this to To do in 1.1.0 Release via automation May 20, 2019
@mpu-creare mpu-creare removed this from To do in 1.1.0 Release Jul 29, 2019
@mpu-creare mpu-creare added this to To do in 1.2.0 Release via automation Jul 29, 2019
@mpu-creare mpu-creare removed this from To do in 1.2.0 Release Nov 1, 2019
@mpu-creare mpu-creare added this to To do in 1.3.0 Release via automation Nov 1, 2019
@mpu-creare mpu-creare removed this from To do in 1.3.0 Release Jan 13, 2020
@mpu-creare mpu-creare added this to To do in 2.0.0 Release via automation Jan 13, 2020
@mpu-creare mpu-creare added this to To do in 2.2.0 via automation Apr 17, 2020
@mpu-creare mpu-creare removed this from To do in 2.0.0 Release Apr 17, 2020
@mpu-creare mpu-creare added this to To do in Priorities via automation Aug 21, 2020
@jmilloy jmilloy moved this from To do to In progress in Priorities Sep 9, 2020
@mpu-creare
Copy link
Contributor

@jmilloy Is this done?

@jmilloy
Copy link
Collaborator Author

jmilloy commented Apr 5, 2021

It is now! I just removed a few stray references to DependentCoordinates. I'm guessing that's why I didn't close this earlier.

@jmilloy jmilloy closed this as completed Apr 5, 2021
Priorities automation moved this from In progress to Done Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Priorities
  
Done
2.2.0
  
To do
Development

No branches or pull requests

2 participants