Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment issue #23

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Fix deployment issue #23

merged 3 commits into from
Jul 9, 2023

Conversation

feryardiant
Copy link
Contributor

Diketahui adanya issue pada project yang ter-deploy ke server. Dimana end-point URL di frontend masih menggunakan local endpoint, hal tersebut kemungkinan besar dikarenakan konfigurasi berikut

env:
APP_NAME: Creasi Skeleton
APP_ENV: testing
APP_URL: http://127.0.0.1:8000
APP_KEY: ${{ secrets.APP_KEY }}

Yang menjadikan setiap form request tidak mengarahkan ke url yang semestinya.

Screenshot 2023-07-09 at 21 51 08

Selain itu, saat ini di project ini ada 2 workflow yaitu main dan build-deploy dimana memiliki job yang sama, yaitu deploy. Bedanya di workflow main deployment khusus untuk branch main saja, dan belum mendukung untuk deployment di branch lain ataupun pull request. Sedangkan workflow build-deploy hanya untuk deployment berbasis tags, yang mana cukup jarang atau jarang sekali digunakan, setidaknya saat ini.

Masalahnya adalah ketika ada perubahan konfigurasi di workflow main, tentu kita juga harus mengubah konfigurasi di build-deploy juga. Yangmana hal tersebut rawan sekali lupa (termasuk saya).

Dalam PR ini saya coba untuk merubah workflow deployment nantinya hanya ada 1 yaitu deploy dengan hanya di-trigger melalui tag (seperti sebelumnya) dan juga di-trigger dari workflow main setelah e2e job selesai.

see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_call

@feryardiant feryardiant added bug: confirmed Something is actually not working enhancement New feature or request deployment Deployment related things experience The way users interact with the product labels Jul 9, 2023
@feryardiant feryardiant self-assigned this Jul 9, 2023
@feryardiant
Copy link
Contributor Author

Let' make use of github variables to store our environment variables

Screenshot 2023-07-09 at 22 18 32

Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
@feryardiant feryardiant merged commit fc2c64e into main Jul 9, 2023
5 of 6 checks passed
@feryardiant feryardiant deleted the fix-deployment-ssue branch July 9, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed Something is actually not working deployment Deployment related things enhancement New feature or request experience The way users interact with the product
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant