set default values of fields of a pointer type field #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And add go.mod |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 98.29% 98.26% -0.03%
==========================================
Files 2 2
Lines 117 115 -2
==========================================
- Hits 115 113 -2
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
creasty
reviewed
Jun 9, 2020
| if defaultVal != "" && defaultVal != "{}" { | ||
| if err := json.Unmarshal([]byte(defaultVal), ref.Interface()); err != nil { | ||
| if err := json.Unmarshal([]byte(defaultVal), field.Addr().Interface()); err != nil { |
defaults.go
Outdated
| return err | ||
| } | ||
| callSetter(ref.Interface()) | ||
| field.Set(ref.Elem()) | ||
| callSetter(field.Addr().Interface()) |
There was a problem hiding this comment.
It seems to be a redundant call as you're already doing it in Set.
Either one of them should be removed. Perhaps the latter.
|
Could you also change the title to be more descriptive? |
sdghchj
changed the title
|
@creasty review again please |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #16 #17