Add new IDs for boards with CircuitPython just ported to them #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 13, 2024
| @@ -9,4 +9,13 @@ Creator ID: 0x1999_1000 | |||
| * `0x00AA_0001` [Sunton ESP32-2432S028](https://www.aliexpress.com/item/1005006556177475.html) | |||
| * `0x00AA_0002` [Sunton ESP32-2424S012](https://www.aliexpress.com/item/1005006300643795.html) | |||
| * `0x00AA_0004` [Sunton ESP32-8048S070](https://www.aliexpress.com/item/1005005099968475.html) | |||
| * `0x00AA_0024` [Sunton ESP32-2432S024](https://www.aliexpress.com/item/1005005865107357.html) | |||
| * `0x00AA_0019` [Sunton ESP32-1732S019](https://www.aliexpress.com/item/1005005059421229.html) | |||
| * `0x00AA_0024` [Sunton ESP32-2432S024C](https://www.aliexpress.com/item/1005005865107357.html) | |||
There was a problem hiding this comment.
This is a duplicate. Please make it unique.
There was a problem hiding this comment.
This still looks like a duplicate of line 12.
|
There is some contention over exactly who one should be listed in this PR (the designer, or the manufacturer(s), neither of which is clear from the boards themselves - I've written to try and find out who wants to front the product) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted new boards. See (e.g.) adafruit/circuitpython#9233 and adafruit/circuitpython#9238
Note that some of these boards have different hardware - e.g. ESP32-2432S028R is the restive-touch variant of the ESP32-2432S028C which already exists here as ESP32-2432S028 (
0x00AA_0001)