Fix a security hole in the static directory server.

creationix · Apr 2, 2010 · 472c01a · 472c01a
1 parent 8b64fad
commit 472c01a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/node-router.js b/lib/node-router.js
@@ -311,7 +311,7 @@ exports.staticDirHandler = function(root, prefix) {
     var filename = req.url.replace(/[\?|#].*$/, '');
     if (prefix) filename = filename.replace(new RegExp('^'+prefix), '');
     // make sure nobody can explore our local filesystem
-    filename = path.join(root, filename.replace(/\.\./g, '.'));
+    filename = path.join(root, filename.replace(/\.\.+/g, '.'));
     if (filename == root) filename = path.join(root, 'index.html');
     loadResponseData(req, res, filename, function(headers, body, encoding) {
       res.writeHead(200, headers);