Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove support for sync latest and stable. I never liked them. Fork i…
…f you want them Change-Id: I9092c5625305f54212625af0c16f7ead73a3d9fa
- Loading branch information
1 parent
273aeee
commit ac9a528
Showing
1 changed file
with
3 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, reducing complexity is good - I'm a fan of this change for the most part
This will be a bit goofy for people upgrading to the latest version of nvm, though (all those 'touched' versions showing up as installed)
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How NVM now knows which versions are available... Without sync to populate structure?
nvm_version don't do syncing.
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XooR: It won't. It's outside the scope of nvm to know what the available versions of node there are. That was only needed for the "latest" and "stable" auto-magic aliases. They really didn't work very well and I don't like them. Besides, it complicates the code and leaves lots of cruft files in my home directory. Now, I can see what's installed and available to me. If I want a new version installed it's not hard to install it.
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XooR, you can still
nvm install vX.Y.Z
and it will still find and install that version like beforeThe main change is that you just need to manually go to http://nodejs.org/ if you want to see what the latest versions are
ac9a528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I can live with that :). Less complexity in program is always good thing