export NODE_PATH on nvm use #342
Conversation
| @@ -421,6 +421,7 @@ nvm() { | |||
| export MANPATH | |||
| export NVM_PATH="$NVM_DIR/$VERSION/lib/node" | |||
| export NVM_BIN="$NVM_DIR/$VERSION/bin" | |||
| export NODE_PATH="$NVM_DIR/$VERSION/lib/node_modules" | |||
There was a problem hiding this comment.
this will need to be unset when nvm deactivate is called - should it also be set as part of the nvm run command?
|
Updated to change NODE_PATH variable on use, run and deactivate |
| else | ||
| NODE_PATH="$NVM_DIR/$VERSION/lib/node_modules:$NODE_PATH" | ||
| fi | ||
| export NODE_PATH | ||
| echo "Running node $VERSION" | ||
| $NVM_DIR/$VERSION/bin/node "${@:3}" |
There was a problem hiding this comment.
instead of the PREVIOUS_NODE_PATH stuff you could just run NODE_PATH=foo $NVM_DIR/$VERSION/bin/node "${@:3}" ?
|
I removed the I tested with the variable NODE_PATH and it was changing on the shell ps: sorry about some possible english mistakes |
|
Tested locally; works for me. |
|
Turns out this should never have been added - global modules should not be requireable, ever. If it's a dependency, it should be an explicit dependency. Reverted as part of #586. |
Added a line to export NODE_PATH variable to solve the not found error for global packages