Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nextTick check for groups. #47

Closed
bminer opened this issue Mar 3, 2013 · 3 comments
Closed

Remove nextTick check for groups. #47

bminer opened this issue Mar 3, 2013 · 3 comments

Comments

@bminer
Copy link

bminer commented Mar 3, 2013

Removing this line would be nice. :)
https://github.com/creationix/step/blob/master/lib/step.js#L102

This would cause issues when no group() has been called, but it would allow groups to be setup later (in callbacks), which would be pretty cool.

@bminer
Copy link
Author

bminer commented Mar 3, 2013

Or, perhaps, for backward compatibility, allow someone to pass options to the this.group() function. Such as this.group({"defer": true}) would disable the process.nextTick check, which is only useful if the group is going to be empty anyway.

@olecom
Copy link

olecom commented Jul 12, 2014

Hi, bminer.

it would allow groups to be setup later (in callbacks), which would be pretty cool

why cool?

@bminer
Copy link
Author

bminer commented Jul 21, 2014

I'm not really sure. :) This issue is over a year old. I'm going to close this issue.

@bminer bminer closed this as completed Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants