Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC 4.0 plain text licenses: third level numbering in lower case but referencing in upper case #286

Open
1 task done
jodeebrowm opened this issue Feb 18, 2021 · 6 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix legalcode licenses 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@jodeebrowm
Copy link

Description

The CC 4.0 plain text licenses use lower characters (a, b, ...) in the third level of the numbering, e.g. Section 2(a)(1) or 2(a)(5), but the internal references use upper case letters (A, B, ...), e.g. Section 2(a)(6) or Section 3(a)(3). This is inconsistent and potentially misleading.

The HTML versions of the license text does consistently use upper cases across all third level enumerations and references.

Expectation

Consistent naming equal to the HTML version.

Resolution

  • I would be interested in resolving this bug.

I would be willing to capitalise those ~30 letters if I get a go ahead.

@TimidRobot
Copy link
Member

A PR would be welcomed! However, before I merge it I will need to verify that it doesn't cause issues with licensee/licensee (as well as search for similar cases where changes could be disruptive).

@TimidRobot TimidRobot added legalcode licenses 🏁 status: ready for work Ready for work 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 5, 2021
@jodeebrowm
Copy link
Author

jodeebrowm commented Mar 21, 2021

Should I combine these changes with the ones in pull request creativecommons/creativecommons.org#1198 / creativecommons/creativecommons.org#1199 ? So we only break licensee et al once.

@nana6956

This comment was marked as spam.

@jodeebrowm
Copy link
Author

Any update on this? As said before, I'm willing to provide a PR but I'm still waiting for an answer on whether to combine this with creativecommons/creativecommons.org#1198 / creativecommons/creativecommons.org#1199.

@jodeebrowm
Copy link
Author

@TimidRobot I've created a pull request for this: creativecommons/creativecommons.org#1240.

Hopefully, this brings this a step closer to being resolved.

@TimidRobot TimidRobot transferred this issue from creativecommons/creativecommons.org Jul 15, 2022
@TimidRobot
Copy link
Member

@jodeebrowm

I moved this issue here to cc-legal-tools-app so that we can solve this more reliably in the future. As the changes required are not simply whitespace and will impact license detection. I want to wait until we have additional changes ready so that coordination burden of upstream projects is minimal.

@TimidRobot TimidRobot added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🏁 status: ready for work Ready for work labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix legalcode licenses 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants