-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language width is fixed for small devices #420
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work! As is, it improves the end-user experience.
However, I think using a Responsive layout technology would behave better than pure Media queries / breakpoints. .ancilliary-menu ul
is already a flex container (vocabulary.css
line 272: display: flex;
). See Flexbox - Learn web development | MDN.
Also, if media queries / breakpoints are required, consider using relative units per Responsive design - Learn web development | MDN:
If using breakpoints, best practices encourage defining media query breakpoints with relative units rather than absolute sizes of an individual device.
|
…d also fix the cc logo for all small devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the cc_legal_tools/static/wp-content
files from this PR
Fixes
Description
Previously, the language option container was only partially visible on mobile device screens, resulting in a poor user experience. However, with recent modifications, the container is now fully visible on all mobile device screens. This enhancement ensures that users can easily access and interact with the language options without any visibility issues.
Tests
To ensure the changes are working as expected, follow these steps:
Verify that the width of language elements adjusts correctly according to the screen size, confirming the applied modifications.
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin