Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language width is fixed for small devices #420

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ShivamAhir
Copy link

@ShivamAhir ShivamAhir commented Mar 5, 2024

Fixes

Description

Previously, the language option container was only partially visible on mobile device screens, resulting in a poor user experience. However, with recent modifications, the container is now fully visible on all mobile device screens. This enhancement ensures that users can easily access and interact with the language options without any visibility issues.

Tests

To ensure the changes are working as expected, follow these steps:

  1. Clone the repository locally.
  2. Install any necessary dependencies.
  3. Run the project locally.
  4. Navigate to http://127.0.0.1:8005/licenses/list.en in your web browser.
  5. Test the layout and functionality across different screen sizes, including small devices.

Verify that the width of language elements adjusts correctly according to the screen size, confirming the applied modifications.

Screenshots

image
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ShivamAhir ShivamAhir requested review from a team as code owners March 5, 2024 07:53
@ShivamAhir ShivamAhir requested review from TimidRobot and annatuma and removed request for a team March 5, 2024 07:53
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Mar 5, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work! As is, it improves the end-user experience.

However, I think using a Responsive layout technology would behave better than pure Media queries / breakpoints. .ancilliary-menu ul is already a flex container (vocabulary.css line 272: display: flex;). See Flexbox - Learn web development | MDN.

Also, if media queries / breakpoints are required, consider using relative units per Responsive design - Learn web development | MDN:

If using breakpoints, best practices encourage defining media query breakpoints with relative units rather than absolute sizes of an individual device.

templates/includes/languages_dropdown.html Outdated Show resolved Hide resolved
templates/includes/languages_dropdown.html Outdated Show resolved Hide resolved
@TimidRobot
Copy link
Member

@ShivamAhir

I think using a Responsive layout technology would behave better than pure Media queries / breakpoints. .ancilliary-menu ul is already a flex container (vocabulary.css line 272: display: flex;). See Flexbox - Learn web development | MDN.

…d also fix the cc logo for all small devices
joker22008

This comment was marked as spam.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the cc_legal_tools/static/wp-content files from this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Code Review
Development

Successfully merging this pull request may close these issues.

[Bug] Improve language option
3 participants