Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: aside container height improved #422 #427

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

keshav861
Copy link
Contributor

@keshav861 keshav861 commented Apr 2, 2024

Fixes

Fixes #422 by @ShivamAhir

Description

App: aside container height improved

This PR redesign the aside container as before the aside container height was extended up to the end of the page. and now after the PR the the aside container height is to the end of the text so it is more visually appealing

Also see Data PR:

Screenshots

Before Changes:-
image

After Changes:-
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@keshav861 keshav861 requested review from a team as code owners April 2, 2024 07:00
@keshav861 keshav861 requested review from TimidRobot and possumbilities and removed request for a team April 2, 2024 07:00
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Apr 2, 2024
@TimidRobot TimidRobot self-assigned this Apr 2, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@TimidRobot TimidRobot merged commit 36ff094 into creativecommons:main Apr 2, 2024
2 checks passed
Active Sprint automation moved this from Code Review to Done Apr 2, 2024
@TimidRobot TimidRobot changed the title aside container height improved #422 App: aside container height improved #422 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Done
Development

Successfully merging this pull request may close these issues.

[Bug] Improve Height of Aside Container
2 participants