Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Fix missing canonical URLs #446

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

TimidRobot
Copy link
Member

@TimidRobot TimidRobot commented May 2, 2024

Fixes

Description

App: Fix missing canonical URLs

  • improve default language logic
    • rename get_default_language_for_jurisdiction to get_default_language_for_jurisdiction_naive
      • primarily used for legal code
    • add get_default_language_for_jurisdiction_deed
      • consults settings.LANGUAGES_MOSTLY_TRANSLATED
  • coincidentally improves hreflang="x-default" behavior for ported deeds

Also see related Data PR:

Tests

command

./dev/coverage

output excerpt:

Name    Stmts   Miss Branch BrPart    Cover   Missing
-----------------------------------------------------
TOTAL    1690      0    638      0  100.00%

20 files skipped due to complete coverage.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

- rename get_default_language_for_jurisdiction to
  get_default_language_for_jurisdiction_naive
  - primarily used for legal code
- add get_default_language_for_jurisdiction_deed
  - consults settings.LANGUAGES_MOSTLY_TRANSLATED
- coincidientally improves hreflang="x-default" behavior for ported
  deeds
@TimidRobot TimidRobot self-assigned this May 2, 2024
@TimidRobot TimidRobot requested review from a team as code owners May 2, 2024 16:53
@TimidRobot TimidRobot added this to Code Review in Active Sprint via automation May 2, 2024
Copy link
Member

@Shafiya-Heena Shafiya-Heena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@TimidRobot TimidRobot merged commit c0bef36 into main May 2, 2024
3 checks passed
@TimidRobot TimidRobot deleted the fix-missing-canonical-urls branch May 2, 2024 17:06
Active Sprint automation moved this from Code Review to Done May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Done
Development

Successfully merging this pull request may close these issues.

[Bug] Canonical URL for some pre-4.0 licenses return 403
3 participants