Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Science museum workflow #411

Merged
merged 5 commits into from May 29, 2020
Merged

Science museum workflow #411

merged 5 commits into from May 29, 2020

Conversation

kss682
Copy link
Contributor

@kss682 kss682 commented May 29, 2020

Fixes

Fixes #408 by @mathemancer

Description

Airflow DAG script to run the science museum script

Technical details

Faced few errors while testing not sure of its origin .
First occurrence of it was when the test passed and removed some comments and then testing again failed .

/tmp/pytest-of-airflow/pytest-0/test_dag_loads_with_no_errors7
[2020-05-29 07:45:54,791] {dagbag.py:403} INFO - Filling up the DagBag from /tmp/pytest-of-airflow/pytest-0/test_dag_loads_with_no_errors7
[2020-05-29 07:45:54,792] {dagbag.py:229} INFO - File /usr/local/airflow/dags/science_museum_workflow.py assumed to contain no DAGs. Skipping.
{}

Mentioning this problem since not sure why this occurred suddenly.
Now the test is passing.

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kss682 kss682 requested review from a team and mathemancer and removed request for a team May 29, 2020 08:23
@kgodey kgodey added this to In Progress in Active Sprint May 29, 2020
@mathemancer
Copy link
Contributor

mathemancer commented May 29, 2020

I think (hope) that the issue was due to the file sync sometimes taking a moment to catch up between your local filesystem (where you were editing) and that of the docker container. Sometimes that can cause issues.

Regardless, I can't replicate it, and the tests are passing at the moment. We'll just keep an eye on it.

Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mathemancer mathemancer merged commit 782ee08 into master May 29, 2020
Active Sprint automation moved this from In Progress to Done May 29, 2020
@mathemancer mathemancer deleted the science_museum_workflow branch May 29, 2020 09:09
@TimidRobot TimidRobot removed this from Done in Active Sprint Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Apache Airflow DAG to run the new science_museum.py script
2 participants