Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit and e2e tests for the LicenseUseCard component #121

Closed
akmadian opened this issue Mar 5, 2020 · 5 comments
Closed

Add unit and e2e tests for the LicenseUseCard component #121

akmadian opened this issue Mar 5, 2020 · 5 comments
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly Hacktoberfest Ideal for Hacktoberfest participation help wanted Open to participation from the community 🏷 status: label work required Needs proper labelling before it can be worked on

Comments

@akmadian
Copy link
Member

akmadian commented Mar 5, 2020

Unit and e2e tests need to be written for the LicenseUseCard component. Unit tests are done with Jest, and e2e tests are done with nightwatch.

Please remember to test the following things:

  • That individual parts of the component are present when appropriate. (unit and e2e)
  • That any computed props and methods work properly, if there are any. (unit)
  • Any common interactions between the user and component, if there are any. (e2e)
  • Any other functionality unique to the component being tested!

Additional Context
@akmadian akmadian added help wanted Open to participation from the community good first issue New-contributor friendly test-coverage labels Mar 5, 2020
@akmadian akmadian changed the title Add unit and e2e tests for the LicenseUseCard Add unit and e2e tests for the LicenseUseCard component Mar 5, 2020
@akmadian akmadian mentioned this issue Mar 5, 2020
Closed
14 tasks
@hemanth-hk
Copy link
Contributor

Can I work on this?

@akmadian
Copy link
Member Author

akmadian commented Mar 8, 2020

@hemanth-hk I'm gonna say no since you've already submitted 2 PRs, let's make sure that others can contribute as well :)

@hemanth-hk
Copy link
Contributor

Okay... I have a small request , when you review my PRs please give me some feedback about how I wrote tests cause I never wrote tests before

@hemanth-hk
Copy link
Contributor

Its been a long time and no one showed any interest so I am working on this :)

@hemanth-hk hemanth-hk mentioned this issue Apr 6, 2020
Closed
7 tasks
@dhruvkb dhruvkb added the Hacktoberfest Ideal for Hacktoberfest participation label Sep 25, 2020
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed test-coverage labels Oct 25, 2020
@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Dec 2, 2020
@obulat
Copy link
Contributor

obulat commented Dec 17, 2020

This issue has been solved.

@obulat obulat closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly Hacktoberfest Ideal for Hacktoberfest participation help wanted Open to participation from the community 🏷 status: label work required Needs proper labelling before it can be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added e2e and unit tests for LicenseUseCard component hemanth-hk/cc-chooser
5 participants
@obulat @dhruvkb @akmadian @hemanth-hk @cc-open-source-bot