Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable scroll on body of website when modal is active. #473

Open
1 task done
soustab10 opened this issue Mar 23, 2023 · 4 comments
Open
1 task done

Disable scroll on body of website when modal is active. #473

soustab10 opened this issue Mar 23, 2023 · 4 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
Backlog

Comments

@soustab10
Copy link
Contributor

Description

When a modal is active, scrolling is still active on the body of the website - which is not particularly a good user experience. It is particularly noticeable in [the terms and intended legal effect of CC0,] modal under Waiver Your Copyright.

Reproduction

  1. Step 1: Go to website .
  2. Step 2: Click on any question under CONFUSED? NEED HELP? section.
  3. Scroll and see error.

Expectation

The body should stay fixed when any modal is open.

Screenshots

Untitled.video.-.Made.with.Clipchamp.7.mp4

Environment

  • Device: Desktop Screens

Resolution

  • I would be interested in resolving this bug.
@soustab10 soustab10 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Mar 23, 2023
@cc-open-source-bot cc-open-source-bot added this to Ready for Development in Active Sprint Mar 23, 2023
@cc-open-source-bot cc-open-source-bot removed this from Ready for Development in Active Sprint Mar 23, 2023
@cc-open-source-bot cc-open-source-bot added this to Pending Review in Backlog Mar 23, 2023
@Cronus1007
Copy link
Member

@soustab10 Everything is appearing to be fine for me.Am I missing something?

@soustab10
Copy link
Contributor Author

@soustab10 Everything is appearing to be fine for me.Am I missing something?

I think the scroll action while the modal is active degrades the user experience. What do you think of it?

SADIK112 added a commit to SADIK112/chooser that referenced this issue Apr 4, 2023
@SADIK112
creativecommons#473 - Disable scroll on body of website when modal is…
2b6a649 
… active
@SADIK112
Copy link

SADIK112 commented Apr 4, 2023

@soustab10 - https://github.com/creativecommons/chooser/pull/482
Made this PR to resolve this issue and disable scroll when the modal gets active.

@possumbilities possumbilities moved this from Pending Review to License Chooser in Backlog Apr 10, 2023
@possumbilities possumbilities mentioned this issue Jun 23, 2023
Closed
@nik132-eng
Copy link

if this issue is not fixed i want to fix this can you please assign me this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
Backlog
  
License Chooser
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#473 - Disable scroll on body of website when modal is active SADIK112/chooser
4 participants
@SADIK112 @Cronus1007 @nik132-eng @soustab10