Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all code using Prettier and eslint #352

Merged
merged 8 commits into from Jun 3, 2021
Merged

Format all code using Prettier and eslint #352

merged 8 commits into from Jun 3, 2021

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Jun 2, 2021

Fixes

Closes #351

Description

Run automated code format on all .js and .vue files.

Technical details

Code formatting should be an automated part of regular development. This pull request fixes project-wide code formatting. This way, we can avoid some additional noise in pull requests where the code would be formatted in an ad-hoc manner.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@brylie brylie requested a review from a team as a code owner June 2, 2021 10:08
@brylie brylie requested review from zackkrida and removed request for a team June 2, 2021 10:08
@brylie brylie changed the title Format all code using Prettier Format all code using Prettier and eslint Jun 2, 2021
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Jun 2, 2021
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

.prettierignore Outdated Show resolved Hide resolved
@brylie brylie requested a review from TimidRobot June 2, 2021 15:56
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npm run lint, it changes the indent in Stepper.vue method stepActionComponent

@brylie
Copy link
Contributor Author

brylie commented Jun 3, 2021

@obulat thanks for the tip! The indentation from npm run lint looks correct to me, so I pushed those changes.

@brylie
Copy link
Contributor Author

brylie commented Jun 3, 2021

I accidentally pushed local changes after making changes on the GitHub branch. I hope we are not too strict about having a linear commit history, although I am comfortable re-running the commits on a fresh branch.

In general, I find the linear history (rebase) constraint to be a bit more trouble than it is worth, having witnessed more difficulty than benefit stemming from the requirement-- particularly in projects with contributors of varying degree of familiarity with Git.

@brylie
Copy link
Contributor Author

brylie commented Jun 3, 2021

@TimidRobot if the code is in good enough shape, would you mind merging this pull request?

@obulat
Copy link
Contributor

obulat commented Jun 3, 2021

The cypress tests are currently failing in CI, @brylie .

@brylie
Copy link
Contributor Author

brylie commented Jun 3, 2021

@obulat the tests run successfully on my local machine. Perhapse it is non-deterministic, since it is involving DOM element visibility when the page scrolls?

@brylie
Copy link
Contributor Author

brylie commented Jun 3, 2021

@obulat I re-ran the checks on the same commit and they succeeded.

@obulat obulat merged commit 541b06b into main Jun 3, 2021
Active Sprint automation moved this from Code Review to Done Jun 3, 2021
@brylie brylie deleted the auto-format-code branch June 3, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Done
Development

Successfully merging this pull request may close these issues.

Inconsistent code formatting througout project
3 participants