New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format all code using Prettier and eslint #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run npm run lint
, it changes the indent in Stepper.vue method stepActionComponent
… into auto-format-code
@obulat thanks for the tip! The indentation from |
I accidentally pushed local changes after making changes on the GitHub branch. I hope we are not too strict about having a linear commit history, although I am comfortable re-running the commits on a fresh branch. In general, I find the linear history (rebase) constraint to be a bit more trouble than it is worth, having witnessed more difficulty than benefit stemming from the requirement-- particularly in projects with contributors of varying degree of familiarity with Git. |
@TimidRobot if the code is in good enough shape, would you mind merging this pull request? |
The cypress tests are currently failing in CI, @brylie . |
@obulat the tests run successfully on my local machine. Perhapse it is non-deterministic, since it is involving DOM element visibility when the page scrolls? |
@obulat I re-ran the checks on the same commit and they succeeded. |
Fixes
Closes #351
Description
Run automated code format on all .js and .vue files.
Technical details
Code formatting should be an automated part of regular development. This pull request fixes project-wide code formatting. This way, we can avoid some additional noise in pull requests where the code would be formatted in an ad-hoc manner.
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin