Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #367, replace node-sass with sass #368

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix: #367, replace node-sass with sass #368

merged 1 commit into from
Dec 23, 2021

Conversation

sadn1ck
Copy link
Contributor

@sadn1ck sadn1ck commented Dec 23, 2021

Signed-off-by: Anik Das anikdas0811@gmail.com

Fixes

Fixes #367 by @brylie

Description

  • removed node-sass
  • installed sass

Technical details

  • there were some warnings during build process which I'm trying to find out if I can fix
  • image

Tests

  • npm run serve and npm run build run without issues
  • all tests pass

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Anik Das <anikdas0811@gmail.com>
@sadn1ck sadn1ck requested a review from a team as a code owner December 23, 2021 18:23
@sadn1ck
Copy link
Contributor Author

sadn1ck commented Dec 23, 2021

Re the warnings, sass warnings cannot be silenced, and, this particular warn is due to this https://sass-lang.com/documentation/breaking-changes/slash-div

This warns are generated within the bulma source, so I think that can be ignored for now till sass hits 2.0, which is when it will break (from what I understood)

Reference:

@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Dec 23, 2021
@brylie brylie merged commit 56c8f28 into creativecommons:main Dec 23, 2021
Active Sprint automation moved this from Code Review to Done Dec 23, 2021
@brylie brylie self-assigned this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Active Sprint
  
Done
Development

Successfully merging this pull request may close these issues.

Replace node-sass with sass
3 participants