Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prettier, eslint and stylelint config and also enable automatic execution #530

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix prettier, eslint and stylelint config and also enable automatic execution #530

wants to merge 8 commits into from

Commits on Apr 21, 2024

  1. Install and configure husky package

    @dijitali
    dijitali committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    960979b View commit details
    Browse the repository at this point in the history

  2. Fix prettier setup 

    Upgrade prettier to latest supported
Downgrade eslint-config-prettier to version that supports eslint v6
Add npm format scripts for prettier
Exclude coverage and dist from prettier execution
Update lint-staged to run prettier
    @dijitali
    dijitali committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    1f24834 View commit details
    Browse the repository at this point in the history

  3. Remove gitHooks config 

    We're using the main husky package, not Yorkie
    @dijitali
    dijitali committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    8f2c44e View commit details
    Browse the repository at this point in the history

  4. Remove conflicting eslint rules 

    As recommended by eslint-config-prettier-check
    @dijitali
    dijitali committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    fca9dae View commit details
    Browse the repository at this point in the history

  5. Only run stylelint via lint-staged on same file pattern as npm run li… 

    …nt does
    @dijitali
    dijitali committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    51ab382 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Run one-off full lint and format

    @dijitali
    dijitali committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8365500 View commit details
    Browse the repository at this point in the history

  2. Run build

    @dijitali
    dijitali committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    494f34a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from dijitali/chore/run-full-lint-format 

    Run full lint format and build
    @dijitali
    dijitali committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f7f8d00 View commit details
    Browse the repository at this point in the history