Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Create category pages that show posts associated with a category. #54

Closed
kgodey opened this issue Mar 25, 2019 · 12 comments · Fixed by #72
Closed

Blog: Create category pages that show posts associated with a category. #54

kgodey opened this issue Mar 25, 2019 · 12 comments · Fixed by #72
Labels
good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@kgodey
Copy link
Member

kgodey commented Mar 25, 2019

We (will once #51 is done) show categories belonging blog posts but there's no way to see all posts in a given category. We should implement that feature and make each category associated with a blog post clickable to see all posts in that category.

@kgodey kgodey added help wanted Open to participation from the community good first issue New-contributor friendly labels Mar 25, 2019
@Anubhavshakya
Copy link

I would like to work on this...

@kgodey
Copy link
Member Author

kgodey commented Mar 27, 2019

You'll need to wait until #51 is done to avoid conflicts since that changes categories as well. If you want to work on something now, I suggest #53 – it's similar but will not have conflicts with existing work.

@kgodey kgodey removed good first issue New-contributor friendly help wanted Open to participation from the community labels Mar 27, 2019
@kgodey
Copy link
Member Author

kgodey commented Mar 27, 2019

I'm removing the labels that indicate it's ready for work until #51 is done.

@kgodey kgodey added help wanted Open to participation from the community good first issue New-contributor friendly labels Apr 1, 2019
@kgodey
Copy link
Member Author

kgodey commented Apr 1, 2019

Adding labels back since #51 is merged.

@makkoncept
Copy link
Member

@kgodey can I work on this issue if no one is working on it.
Thanks

@kgodey
Copy link
Member Author

kgodey commented Apr 3, 2019

Go ahead

@kgodey
Copy link
Member Author

kgodey commented Apr 3, 2019

@makkoncept I made some changes to the URLs and categories in #61, please merge that into your branch early to avoid merge conflicts.

@makkoncept
Copy link
Member

okay, will do 👍

@makkoncept
Copy link
Member

@kgodey I noticed #62 (generating author pages for multiple blogs) . I think we should also do this for categories so that structure of the blog can be consistent.
If you think so, shall I do this in this PR itself as I have not commited the changes yet or opening a new issue would be a good idea?

@kgodey
Copy link
Member Author

kgodey commented Apr 5, 2019

Please do it in this PR, thanks!

@kgodey
Copy link
Member Author

kgodey commented Apr 15, 2019

@makkoncept FYI, I updated some styles/text and fixed author pages which broke, see: 1304f57...a632954

Internal links also broke, I fixed in: 704788f

(I should have caught these during code review, sorry).

@makkoncept
Copy link
Member

@kgodey I am sorry, I should have checked it. I will be more careful now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
3 participants