New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy this code [...]" boxes: Selecting a fragment selects all #681

Closed
Chealer opened this Issue Oct 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Chealer

Chealer commented Oct 1, 2017

If I go to https://creativecommons.org/choose/?lang=en and try selecting - for example - a URL in the "Copy this code to let your visitors know!" textarea, the actual selection becomes the whole textarea's content when I release the primary mouse button.

This happens at least in Microsoft Internet Explorer and Google Chrome 61.

@robmyers robmyers self-assigned this Mar 7, 2018

@robmyers robmyers added the wontfix label Mar 7, 2018

@robmyers

This comment has been minimized.

Show comment
Hide comment
@robmyers

robmyers Mar 7, 2018

Contributor

This is intentional behaviour to help people copy the metadata block correctly.

I agree that it's frustrating when one wishes to copy only part of it, but that's the less common case and we can always copy it to a text editor to extract the required section.

Contributor

robmyers commented Mar 7, 2018

This is intentional behaviour to help people copy the metadata block correctly.

I agree that it's frustrating when one wishes to copy only part of it, but that's the less common case and we can always copy it to a text editor to extract the required section.

@robmyers robmyers closed this Mar 7, 2018

@Chealer

This comment has been minimized.

Show comment
Hide comment
@Chealer

Chealer Mar 7, 2018

Thanks @robmyers,
It could be intentional, except the selection should then encompass the whole text as soon as the primary button is pushed, not just when it is released (as happens after one has tried to select a fragment once).

Other avenues to fix while still being very friendly with those who want the whole code:

  1. Make "Copy this code" a button to select all
  2. Simply make the code zone larger so there is no scroll bar. Just using the whole width would probably suffice.

Adding buttons to select just URL-s would also reduce impact.

Chealer commented Mar 7, 2018

Thanks @robmyers,
It could be intentional, except the selection should then encompass the whole text as soon as the primary button is pushed, not just when it is released (as happens after one has tried to select a fragment once).

Other avenues to fix while still being very friendly with those who want the whole code:

  1. Make "Copy this code" a button to select all
  2. Simply make the code zone larger so there is no scroll bar. Just using the whole width would probably suffice.

Adding buttons to select just URL-s would also reduce impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment