Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Expand docker-compose.yml file to include composer and phpcs functionality #201

Open
1 of 6 tasks
possumbilities opened this issue Jul 19, 2022 · 2 comments
Open
1 of 6 tasks
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Milestone

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Jul 19, 2022

Problem

See #199, this builds from there.

MVP
At a minimum:

 - setup MySQL server (MariaDB preferably)
 - setup a web server (Apache), running latest WordPress files
 - make Web and DB server connect with each other appropriately
 - mount the db locally, so it persists
 - mount the WordPress install locally, so it persists
 - mount the wp-plugin-creativecommons plugin directory into the web server at wp-content/plugins/, so it can be user activated
-  include appropriate .gitignore additions so local mount points are not tracked ( ./dev/db & ./dev/wordpress)
 update documentation to reflect new docker compose one-liner referencing docker-compose.yml file

The baseline Docker Image would benefit from having Composer bundled in via the official Composer docker image, so that at a minimum the official WordPress Coding Standards rules for phpcs can be installed easily and configured for dev use. At current, the baseline image leaves this up to the individual dev to install and configure, bundling it here makes setup smoother.

Description

Once #199 is implemented, then as an expansion, Composer could be added in the docker-compose.yml file to allow more well defined testing. Then, the official WordPress Coding Standards rules for phpcs can be installed.

This would then allow proper WordPress coding standards to be applied, and tested.

MVP

  • setup composer image in docker-compose.yml file
  • link to web server
  • setup and configure official phpcs for WordPress Coding Standards via composer (https://github.com/WordPress/WordPress-Coding-Standards)
  • update any relevant documentation for use of composer in this context
  • update any relevant documentation for use of phpcs in this context

Alternatives

There are currently no known official alternatives to the WordPress Coding Standards rules for phpcs that I am aware of.

Additional context

Implementation

  • I would be interested in implementing this feature.
@possumbilities possumbilities added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jul 19, 2022
@possumbilities possumbilities self-assigned this Jul 19, 2022
@possumbilities possumbilities added this to the Backlog milestone Jul 19, 2022
@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 19, 2022
@possumbilities possumbilities modified the milestones: Backlog, v2022.08.1 Jul 19, 2022
@cc-open-source-bot cc-open-source-bot added this to Ready for Development in Active Sprint Jul 19, 2022
@cc-open-source-bot cc-open-source-bot removed this from Ready for Development in Active Sprint Jul 19, 2022
@cc-open-source-bot cc-open-source-bot added this to Pending Review in Backlog Jul 19, 2022
@possumbilities possumbilities moved this from Pending Review to WordPress Plugin in Backlog Jul 25, 2022
@possumbilities possumbilities modified the milestones: v2022.09.1, v2022.10.1 Sep 9, 2022
@AK4266
Copy link

AK4266 commented Mar 17, 2023

I would like to work on this issue can you assign it to me

@possumbilities
Copy link
Contributor Author

@AK4266 sure! ❤️

@AK4266 AK4266 removed their assignment Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Backlog
  
WordPress Plugin
Development

No branches or pull requests

2 participants