Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/v2 fix todos #26

Merged
merged 4 commits into from
Jan 6, 2019
Merged

Feature/v2 fix todos #26

merged 4 commits into from
Jan 6, 2019

Conversation

rohan-deshpande
Copy link
Collaborator

Added

  • Base energize method on the Behaviour abstract class. Sub classes now call this method in their applyBehaviour method rather than the parent's applyBehaviour method

Changed

  • Pool now throws an error if it can neither instantiate or clone the object passed

Removed

  • Unused args from Emitter createParticle and setupParticle methods

@rohan-deshpande rohan-deshpande merged commit 406bd40 into feature/v2 Jan 6, 2019
@rohan-deshpande rohan-deshpande deleted the feature/v2-fix-todos branch January 6, 2019 06:38
@rohan-deshpande rohan-deshpande mentioned this pull request Jan 6, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rohan-deshpande